-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add review links #213
feat: add review links #213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot.
It seems you forgot to add yourself for tests as well. |
I could not determine your intention. Basic usage: @all-contributors please add @jakebolam for code, doc and infra For other usages see the documentation |
@all-contributors Please add @MarceloAlves for test |
I've put up a pull request to add @MarceloAlves! 🎉 |
🎉 This PR is included in version 6.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What: Adding the linking of reviews made by the user
Why: Noticed that the link was just an anchor
#review-marceloalves
and since search params can be used on both GitHub/GitLab to filter PR's by reviewer, I thought I would add thisHow: Followed how
getLinkToIssues
andgetLinkToCommits
were implemented. AddedgetLinkToReviews
with URL template + testsChecklist: